Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate additional inputs from native dependencies #858

Merged
merged 9 commits into from
Jul 30, 2021

Conversation

krasimirgg
Copy link
Collaborator

@krasimirgg krasimirgg commented Jul 28, 2021

Pass additional inputs from native dependencies (e.g., linker scripts) as inputs to the compile action.

@google-cla google-cla bot added the cla: yes label Jul 28, 2021
@krasimirgg krasimirgg changed the title propagate additional native inputs propagate additional inputs from native dependencies Jul 28, 2021
@krasimirgg krasimirgg marked this pull request as ready for review July 28, 2021 10:23
@krasimirgg krasimirgg requested a review from hlopko July 28, 2021 10:23
rust/private/rustc.bzl Outdated Show resolved Hide resolved
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one question but think @hlopko would probably be the better reviewer here.

rust/private/rustc.bzl Outdated Show resolved Hide resolved
Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! One final comment.

rust/private/rustc.bzl Outdated Show resolved Hide resolved
@hlopko hlopko merged commit 72cc0aa into bazelbuild:main Jul 30, 2021
@krasimirgg krasimirgg deleted the additional-link-inputs branch July 30, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants