Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples using openssl to no longer assume a relative path to it #879

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Aug 7, 2021

This updates the way openssl is located for certain examples which relies on it. The rules_foreign_cc example exposes the same target which has proven to be more accurate in more places (at least in my experience).

@google-cla google-cla bot added the cla: yes label Aug 7, 2021
@UebelAndre UebelAndre marked this pull request as ready for review August 7, 2021 22:03
@UebelAndre UebelAndre force-pushed the openssl branch 2 times, most recently from af3d4e0 to ffa4d15 Compare August 9, 2021 01:16
@UebelAndre
Copy link
Collaborator Author

Odd that CI would succeed on in builds/4029 but then after running git commit --amend --date=now && git push -f, (no changes made), CI would fail on windows: builds/4046

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me if it works for CI!

@UebelAndre UebelAndre merged commit b087d94 into bazelbuild:main Aug 12, 2021
@UebelAndre UebelAndre deleted the openssl branch August 12, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants