Temporarily disable rust_doc_test targets on windows
#888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
approved these changes
Aug 12, 2021
|
I'll take the liberty to merge this right away, to fix the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's by no means ideal to disable these tests but there's currently no known solution and this is blocking all other PRs to the project. As far as I'm aware,
rust_doc_testcontinues to work on some (the previous) windows environments but additional work will need to be done to update this rule to consistently work everywhere.related to:
rust_doc_testtargets are currently broken on windows #887