Updated rules_nodejs for wasm_bindgen rules
#890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is waiting on the actual release of |
|
Also, it seems |
UebelAndre
force-pushed
the
wasm
branch
2 times, most recently
from
5e76c1d
to
50fa4e2
Compare
|
Actually, rebasing on top of #865 works since in that PR, the |
UebelAndre
force-pushed
the
wasm
branch
3 times, most recently
from
6603764
to
7c9c5d0
Compare
|
With rules_nodejs 4.0.0 out now, this PR can be merged. |
illicitonion
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_nodejs made some updates to the names of some symbols. This PR picks those up so
rules_rustmay also benefit.