Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated rules_foreign_cc version for examples #895

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Updated rules_foreign_cc version for examples #895

merged 4 commits into from
Aug 18, 2021

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Aug 17, 2021 •
edited
Loading

This PR also enables the sys examples for windows which is supported by updates to rules_foreign_cc

@google-cla google-cla bot added the cla: yes label Aug 17, 2021
@UebelAndre UebelAndre force-pushed the foreign_cc branch 9 times, most recently from 9b24030 to 45a280a Compare August 18, 2021 12:55
@UebelAndre UebelAndre marked this pull request as ready for review August 18, 2021 12:56
illicitonion
illicitonion approved these changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

examples/third_party/openssl/openssl_repositories.bzl Outdated Show resolved Hide resolved
@UebelAndre UebelAndre merged commit e21071a into bazelbuild:main Aug 18, 2021
@UebelAndre UebelAndre deleted the foreign_cc branch August 18, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@UebelAndre @illicitonion