Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting visibility on cargo_build_scripts #903

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

illicitonion
Copy link
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes label Aug 20, 2021
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

One question, and buildifier/docs seems unhappy

cargo/cargo_build_script.bzl Show resolved Hide resolved
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!!

@UebelAndre UebelAndre merged commit 392b17c into bazelbuild:main Aug 24, 2021
@illicitonion illicitonion deleted the cbs-visibility branch August 25, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants