Update deps #929
Update deps #929
Conversation
|
I think this is dropping the |
|
Yes - I don't want to maintain a long-term fork, and I want to start pulling in |
illicitonion
force-pushed
the
update-deps
branch
14 times, most recently
from
aad256b
to
bcfe7a4
Compare
cargo/cargo_bootstrap.bzl
Outdated
| @@ -55,12 +55,17 @@ def cargo_bootstrap( | |||
| if build_mode == "release": | |||
| args.append("--release") | |||
|
|
|||
| env = {} | |||
|
|
|||
| if repository_ctx.attr.include_perl_on_windows and "win" in repository_ctx.os.name: | |||
There was a problem hiding this comment.
Instead of always using setting PERL here, could the cargo_bootstrap_repository rule take an env section which allows users to set these?
There was a problem hiding this comment.
I added a windows_env_vars_to_labels which does this just on Windows, but it feels still pretty similarly specific...
There was a problem hiding this comment.
windows_env_vars_to_labels to me is an improvement but not quite what I had in mind. Would something like #932 work for you?
There was a problem hiding this comment.
Works for me! Though exactly which triple I should be using for "Whatever CI is on Windows" I'm not sure :D
There was a problem hiding this comment.
I'd probably just use:
x86_64-pc-windows-gnu
x86_64-pc-windows-msvc
Perhaps that section could be expanded to support matching on components of a triple, system, vendor, etc... Host detection is not the easiest thing to do sadly... I wish there was more in Bazel to make this easy.
illicitonion
force-pushed
the
update-deps
branch
4 times, most recently
from
59a8ce6
to
c4e013b
Compare
illicitonion
force-pushed
the
update-deps
branch
from
c4e013b
to
ecc132e
Compare
.bazelci/presubmit.yml
Outdated
| @@ -223,6 +225,7 @@ tasks: | |||
| platform: windows | |||
| environment: | |||
| RULES_RUST_CRATE_UNIVERSE_BOOTSTRAP: true | |||
| OPENSSL_STATIC: "1" | |||
There was a problem hiding this comment.
Could this potentially be passed as an env attribute to the bootstrap definition to avoid having two places where environment variables are set?
Co-authored-by: UebelAndre <github@uebelandre.com>
No description provided.