Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rbe_preconfig for RBE toolchain config #958

Merged
merged 4 commits into from
Sep 29, 2021
Merged

Use rbe_preconfig for RBE toolchain config #958

merged 4 commits into from
Sep 29, 2021

Conversation

coeuvre
Copy link
Member

@coeuvre coeuvre commented Sep 29, 2021

rbe_autoconfig doesn't support Bazel 5.0.0+. Use rbe_preconfig instead.

@google-cla google-cla bot added the cla: yes label Sep 29, 2021
@coeuvre
Copy link
Member Author

coeuvre commented Sep 29, 2021

rbe_preconfig uses json module internally which is only available in Bazel 4.0.0+. Hence, it is disabled by default and only enabled on RBE platforms.

@coeuvre coeuvre mentioned this pull request Sep 29, 2021
Closed
@hlopko hlopko self-requested a review September 29, 2021 08:03
hlopko
hlopko approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@hlopko hlopko merged commit e83c39d into bazelbuild:main Sep 29, 2021
@coeuvre coeuvre deleted the fix-rbe-config branch September 29, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlopko hlopko hlopko approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coeuvre @hlopko