Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote build #96

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Fix remote build #96

merged 1 commit into from
Jun 11, 2018

Conversation

damienmg
Copy link
Collaborator

@damienmg damienmg commented Jun 11, 2018

Tested with local docker build

This was broken by #90. @acmcarther @nlopezgi

Tested with local docker build
@damienmg
Copy link
Collaborator Author

/cc @nlopezgi because I typo'd his login on sending the PR

@mfarrugi mfarrugi merged commit ef77316 into bazelbuild:master Jun 11, 2018
@mfarrugi
Copy link
Collaborator

@damienmg @buchgr is is possible to check this in the CI now or will it be in the near future?

@nlopezgi
Copy link
Contributor

thanks for sending this fix, I will test it with remote execution once its in and let you know if I run into issues.

@nlopezgi
Copy link
Contributor

Tested successfully with remote execution. afaik, it should be now possible to setup CI to test your rules with remote execution. I will sync up with @buchgr to provide more info.

@xingao267
Copy link
Member

I added the config to test rules_rust on RBE in #111, but it seems there are a lot of tests failing on RBE due to some commits between this one and 1944c8a.

@damienmg damienmg deleted the fix-remote-build branch November 10, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants