Add incompatible_make_rust_providers_target_independent flag
#967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
approved these changes
Oct 12, 2021
| @@ -339,3 +340,11 @@ def is_exec_configuration(ctx): | |||
|
|
|||
| # TODO(djmarcin): Is there any better way to determine cfg=exec? | |||
| return ctx.genfiles_dir.path.find("-exec-") == -1 | |||
|
|
|||
| def transform_deps(deps, make_rust_providers_target_independent): | |||
There was a problem hiding this comment.
Once we flip the flag this function may be removed, could you document that in the stardoc, potentially adding a todo referencing the issue.
rust/toolchain.bzl
Outdated
| @@ -229,6 +230,8 @@ def _rust_toolchain_impl(ctx): | |||
| if ctx.attr.target_triple and ctx.file.target_json: | |||
| fail("Do not specify both target_triple and target_json, either use a builtin triple or provide a custom specification file.") | |||
|
|
|||
| make_rust_providers_target_independent = getattr(ctx.attr, "_incompatible_make_rust_providers_target_independent")[IncompatibleFlagInfo] | |||
There was a problem hiding this comment.
If you're certain that the current rule has the attribute, (therefore you don't need to provide the default value when attr is missing) you don't have to use the getattr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag guards the incompatible changes needed in order to be able to compile files in aspects. For more information see #966.