Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip default incompatible flag value for #591 #995

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Oct 25, 2021

See details in #591 (and let's have any potential discussions there).

@google-cla google-cla bot added the cla: yes label Oct 25, 2021
@hlopko hlopko changed the title Flip default value Flip default incompatible flag value for https://github.com/bazelbuild/rules_rust/issues/591 Oct 25, 2021
@hlopko hlopko changed the title Flip default incompatible flag value for https://github.com/bazelbuild/rules_rust/issues/591 Flip default incompatible flag value for #591 Oct 25, 2021
@hlopko hlopko marked this pull request as ready for review October 25, 2021 17:44
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@hlopko hlopko merged commit 0c53d0e into bazelbuild:main Oct 27, 2021
@hlopko hlopko deleted the flip_591_to_true branch October 27, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants