Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about source-maps #44

Open
alexeagle opened this issue Aug 14, 2018 · 3 comments
Open

Warning about source-maps #44

alexeagle opened this issue Aug 14, 2018 · 3 comments

Comments

@alexeagle
Copy link
Contributor

A build at latest version reports

WARNING: source-map-support module not installed.
   Stack traces from languages like TypeScript will point to generated .js files.

The sass.dart.js file in the npm:sass distro ends with

//# sourceMappingURL=sass.dart.js.map

but no such file is in the distro.

We should either:

  1. include that sourcemap in the repo and include source-map-support in the build_bazel_rules_sass_compiletime_deps repo so that crashes of the sass tool will report Dart line numbers (probably useful for project maintainers
  2. Update to newer rules_nodejs and set install_source_map_support = False in @io_bazel_rules_sass//sass:sass_bin to suppress the warning
@nex3
Copy link
Collaborator

nex3 commented Aug 14, 2018

There's a third option: remove the comment from the generated source file in the first place. Since the npm package doesn't (currently) ship with the source map, this probably makes sense independent of Bazel support.

@alexeagle
Copy link
Contributor Author

Even if you remove the source mapping line, you still need to do option 2 because we don't read the file to determine whether to enable source mapping. (I suppose we could, but we'd have to read all .js files that might be loaded during the program execution, which is all the action inputs in theory)

@nex3
Copy link
Collaborator

nex3 commented Aug 15, 2018

Ah, okay. I'll do option 2 as well.

gonzojive pushed a commit to gonzojive/rules_sass that referenced this issue Feb 19, 2023
GitHub had promised that their source archives would have stable checksums, but then there was a big Bazel outage yesterday due to their changing it.
Even if they do make such a guarantee and stick to it, we also have the problem that GitHub doesn't give download metrics on their source archive so this is still worth changing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants