Introduce build setting for current Scala version #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simuons
requested changes
Mar 26, 2024
|
Also big thanks for
that was puzzling me in previous pr. |
simuons
reviewed
Mar 26, 2024
scala_config.bzl
Outdated
| @@ -39,8 +50,19 @@ def _store_config(repository_ctx): | |||
| "ENABLE_COMPILER_DEPENDENCY_TRACKING=" + enable_compiler_dependency_tracking, | |||
| ]) | |||
|
|
|||
| build_file_content = "\n".join([ | |||
| 'load("@bazel_skylib//rules:common_settings.bzl", "string_flag")', | |||
| "string_flag(", | |||
There was a problem hiding this comment.
Maybe we should keep this as string_setting for now and do not allow to change this via command line? wdyt?
There was a problem hiding this comment.
Indeed, I see no use case for a flag at the moment.
simuons
approved these changes
Mar 27, 2024
Co-authored-by: mkuta <mkuta@virtuslab.com>
|
Updated the name of config setting as suggested in #1559 (comment) |
liucijus
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build setting & config setting to transition and query about the Scala version.
A small change compared to #1552 is that I don't allow an empty string value for the build setting.
This shouldn't change any behavior.
Motivation
Originally #1290.
Partitioned from #1552.