Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that shows failure of current exports handling #30

Merged
merged 2 commits into from
Apr 15, 2016

Conversation

jcoveney
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jcoveney
Copy link
Contributor Author

Would love to know how to tie this email to stripe's corporate one :) Or since this isn't my corporate email, should I sign one regardless?

@johnynek
Copy link
Member

did you not add stripe's email to this account, or do you have two accounts?


object A {
def main(args: Array[String]) {
println("4 8 15 16 23 42")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. :)

@jcoveney
Copy link
Contributor Author

I guess I need to add stripe's email to this account

@jcoveney
Copy link
Contributor Author

BTW, I pushed a fix to this. I tried a couple bigger refactors, but the issue is that... this is really what it seems we want. We don't do anything more fancy with this information, we just don't want to include the ijars -- everything else is there.

I think we should consider a more principled refactor of this, but this fixes the bug... anything bigger imo is trickier than it seems, and I just want to unblock the scrooge work for now

@jcoveney jcoveney mentioned this pull request Apr 15, 2016
@@ -200,13 +202,17 @@ def _lib(ctx, non_macro_lib):

if not non_macro_lib:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the defensive thing is to move this above line 198. We don't have a test that fails now, but macros should need scala-reflect at compile time (maybe not runtime). It may be that somehow we are putting scala reflect on every classpath elsewhere.

@johnynek johnynek merged commit df54dd9 into bazelbuild:master Apr 15, 2016
@jcoveney jcoveney deleted the jco/embrace_the_python branch April 15, 2016 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants