create provider conditionally based on existence of attribute #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes compatibility with 0.7.0 onwards
|
the first commit shows as failed by checks since I manually cancelled the travis builds in hopes of freeing up capacity for the new commit |
|
Sure thing. It was a tricky one since the "right" fox of using the feature
fell through (the API apparently doesn't support exports) and the comment
talked about Bazel >=0.6.0 but it was actually released in 0.7.0
Only until I realized it I figured out I have an easy enough fix
…On Sun, 29 Oct 2017 at 20:19 P. Oscar Boykin ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for fixing this @ittaiz <https://github.com/ittaiz>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#325 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIFz6o3o850bnPCEAtYOthRO_WNxBcks5sxMHAgaJpZM4QKNOI>
.
|
nmurthy
pushed a commit
to zenreach/rules_scala
that referenced
this pull request
Dec 18, 2017
…uild#325) * create provider conditionally based on existence of attribute fixes compatibility with 0.7.0 onwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes compatibility with 0.7.0 onwards
fixes #280
fixes #314
fixes bazelbuild/bazel#3792
Good news:
Small and easy fix. Identical to what @lberki did but just for the additional provider that was added.
Bad news:
Actually utilizing the feature @iirina exposed for us proves to be more tricky than expected for two reasons:
create_providerAPI doesn't take into accountexportsNote:
The provider is hardcoded to not create an ijar exactly due to the problems above. The current fix is just to play nice with the skylark API and sidestep the new feature.