Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #60 by clarifying the getting started path #64

Merged
merged 1 commit into from
May 25, 2016

Conversation

ittaiz
Copy link
Member

@ittaiz ittaiz commented May 24, 2016

@johnynek I took the liberty of adding another sentence about the prelude since that by itself was another gotcha for me when I started out

@bazel-io
Copy link
Member

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@johnynek
Copy link
Member

@ittaiz can you sign the google CLA, and then I will merge your PR?

@ittaiz
Copy link
Member Author

ittaiz commented May 24, 2016

Will do soon, waiting for our "people" to give me the green light
On יום ג׳, 24 במאי 2016 at 21:59 P. Oscar Boykin notifications@github.com
wrote:

@ittaiz https://github.com/ittaiz can you sign the google CLA, and then
I will merge your PR?


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#64 (comment)

@ittaiz
Copy link
Member Author

ittaiz commented May 25, 2016

I signed it!

@ittaiz
Copy link
Member Author

ittaiz commented May 25, 2016

I signed it as Wix.com btw with my email as the contact person

@johnynek johnynek added cla: yes and removed cla: no labels May 25, 2016
@johnynek johnynek merged commit 931857d into bazelbuild:master May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants