Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Replace maven_jar with maven_install #887

Closed
wants to merge 2 commits into from

Conversation

laszlocsomor
Copy link

This should fix building this repo with Bazel@HEAD (and the upcoming Bazel 2.0 version).

Context: bazelbuild/bazel#6799

Description

Replace native maven_jar rules with maven_install from https://github.com/bazelbuild/rules_jvm_external.

See https://github.com/bazelbuild/rules_jvm_external/blob/master/README.md

Motivation

Bazel 2.0 will remove support for the native maven_jar rule. Bazel@HEAD can no longer run bazel info in this repo because of the maven_jar rules in the WORKSPACE.

@laszlocsomor laszlocsomor changed the title Replace maven_jar with maven_install WIP: Replace maven_jar with maven_install Nov 28, 2019
@laszlocsomor
Copy link
Author

This breaks //third_party/dependency_analyzer/src/test:dependency_analyzer_test, haven't yet foudn out why.

@ittaiz
Copy link
Member

ittaiz commented Nov 28, 2019

Do you know @jin is already working on replacing maven jar here?

@jin
Copy link
Member

jin commented Nov 28, 2019

@laszlocsomor Hey, thanks for this PR! I'm working on extending the migration tooling in rules_jvm_external to target jvm_maven_import_external instead of maven_install instead. See #871 for more details.

@laszlocsomor
Copy link
Author

Thank you both, I wasn't aware. Thanks Jin for working on this! I'll revert this PR.

@laszlocsomor laszlocsomor deleted the maven-jar branch November 29, 2019 08:27
gergelyfabian pushed a commit to gergelyfabian/rules_scala that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants