Skip to content

Commit

Permalink
Disable allow_multiple for per_module_swiftcopt_flag
Browse files Browse the repository at this point in the history
Bazel doesn't support this yet
  • Loading branch information
keith committed May 4, 2021
1 parent ee7e6e3 commit 51a8f82
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions swift/internal/build_settings.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def additional_per_module_swiftcopts(label, provider):
def _per_module_swiftcopt_flag_impl(ctx):
# Each item in this list should of the form
# "<target label>=<comma separated copts>".
module_and_copts_list = ctx.build_setting_value
# TODO: Remove extra list once allow_multiple is enabled
module_and_copts_list = [ctx.build_setting_value]
value = dict()
for item in module_and_copts_list:
if not item:
Expand Down Expand Up @@ -72,7 +73,7 @@ def _per_module_swiftcopt_flag_impl(ctx):
per_module_swiftcopt_flag = rule(
build_setting = config.string(
flag = True,
allow_multiple = True,
# allow_multiple = True, # TODO: Enable once bazel supports it
),
# TODO(b/186869451): Support adding swiftcopts by module name in addition
# to the target label.
Expand Down

0 comments on commit 51a8f82

Please sign in to comment.