Revert "Add support for imported_library when linking (#917)" #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With recent rules_apple updates, libraries are added both to CcInfo and ObjcProvider's imported_library, which results in duplicate symbols. Removing this and only relying on CcInfo for this is the path moving forward. Theoretically a custom rule that produced objc info with imported_librarys would be broken by this, but they will have to migrate either way as this provider goes away for linking. This reverts commit b83db34.
|
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/826 (must be Lyft employee to view) |
brentleyjones
approved these changes
Mar 8, 2023
keith
requested review from
BalestraPatrick,
segiddins,
thii and
mattrobmattrob
as code owners
keith
deleted the
ks/revert-add-support-for-imported_library-when-linking-917
branch
|
This breaks Bazel 5, since those users can't upgrade to a newer version of rules_apple. |
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
…" (bazelbuild#1020) With recent rules_apple updates, libraries are added both to CcInfo and ObjcProvider's imported_library, which results in duplicate symbols. Removing this and only relying on CcInfo for this is the path moving forward. Theoretically a custom rule that produced objc info with imported_librarys would be broken by this, but they will have to migrate either way as this provider goes away for linking. This reverts commit b83db34.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent rules_apple updates, libraries are added both to CcInfo and
ObjcProvider's imported_library, which results in duplicate symbols.
Removing this and only relying on CcInfo for this is the path moving
forward. Theoretically a custom rule that produced objc info with
imported_librarys would be broken by this, but they will have to migrate
either way as this provider goes away for linking.
This reverts commit b83db34.