Disable autolinking for dynamic frameworks #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When linking with the objc provider, we use `-F` and `-framework` to link dynamic frameworks. With CcInfo we pass the binary path directly to the linker instead, meaning any autolink commands like `-framework foo` are invalid.
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
brentleyjones
approved these changes
Mar 8, 2023
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
When linking with the objc provider, we use `-F` and `-framework` to link dynamic frameworks. With CcInfo we pass the binary path directly to the linker instead, meaning any autolink commands like `-framework foo` are invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linking with the objc provider, we use
-Fand-frameworktolink dynamic frameworks. With CcInfo we pass the binary path directly to
the linker instead, meaning any autolink commands like
-framework fooare invalid.