Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove grep_includes #1099

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Remove grep_includes #1099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions swift/internal/linking.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ def create_linking_context_from_compilation_outputs(
additional_inputs = additional_inputs,
disallow_static_libraries = False,
disallow_dynamic_library = True,
grep_includes = None,
)

def new_objc_provider(
Expand Down Expand Up @@ -327,7 +326,6 @@ def register_link_binary_action(
cc_feature_configuration,
compilation_outputs,
deps,
grep_includes, # buildifier: disable=unused-variable
name,
output_type,
owner,
Expand All @@ -349,7 +347,6 @@ def register_link_binary_action(
files that will be passed to the linker.
deps: A list of targets representing additional libraries that will be
passed to the linker.
grep_includes: Used internally only.
name: The name of the target being linked, which is used to derive the
output artifact.
output_type: A string indicating the output type; "executable" or
Expand Down
8 changes: 0 additions & 8 deletions swift/internal/swift_binary_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,6 @@ into the binary. Possible values are:
),
providers = [[CcInfo]],
),
# TODO(b/119082664): Used internally only.
"_grep_includes": attr.label(
allow_single_file = True,
cfg = "exec",
default = Label("@bazel_tools//tools/cpp:grep-includes"),
executable = True,
),
},
)

Expand Down Expand Up @@ -274,7 +267,6 @@ def _swift_linking_rule_impl(
# This is already collected from `linking_context`.
compilation_outputs = None,
deps = ctx.attr.deps + extra_link_deps,
grep_includes = ctx.file._grep_includes,
name = binary_path,
output_type = "executable",
owner = ctx.label,
Expand Down