-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Args file format from multiline to shell #61
Conversation
With the shell file format arguments on each line are quoted, which makes these use cases compatible with files with spaces in their paths.
So I actually found a problem with this a little further down the chain. Setting this results in this flag being wrapped in quotes |
The specific clang command (found using
Which results in this error:
Because both |
I am able to workaround this by setting |
Thinking more about this, this might be because of how we're forwarding the arguments to python's check_output. Because this only happens when going through our WIP persistent worker. I'll investigate further |
It actually looks like libtool handles spaces in file paths in these files, so quoting it is redundant and invalid. To be safe I think I'll change this to only quote the Swift place as long as this builds otherwise |
With the shell file format arguments on each line are quoted, which makes these use cases compatible with files with spaces in their paths. Closes #61. PiperOrigin-RevId: 215446371
With the shell file format arguments on each line are quoted, which makes these use cases compatible with files with spaces in their paths. Closes bazelbuild#61. PiperOrigin-RevId: 215446371
With the shell file format arguments on each line are quoted, which
makes these use cases compatible with files with spaces in their paths.