Fix runfiles lookup under bzlmod in Bazel 6 #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
requested review from
brentleyjones,
keith,
segiddins and
thii
as code owners
brentleyjones
requested changes
Jan 5, 2023
BalestraPatrick
force-pushed
the
fix-bzlmod-runfiles
branch
from
fb93827
to
bf2e648
Compare
|
Mmh, failure looks related to This was because of #918, so maybe we can go back to actually using the last green if fixed. |
brentleyjones
approved these changes
Jan 5, 2023
BalestraPatrick
added a commit
that referenced
this pull request
Jan 5, 2023
BalestraPatrick
force-pushed
the
fix-bzlmod-runfiles
branch
from
bf2e648
to
b5688b3
Compare
BalestraPatrick
force-pushed
the
fix-bzlmod-runfiles
branch
from
b5688b3
to
1848a7b
Compare
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
Reverts bazelbuild#918 and unblocks bazelbuild#963.
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
When building Swift code with `--enable_bzlmod`, it currently fails due to the worker failing to find the `index-import` executable in the runfiles. This is because the naming is different under bzlmod and the C++ runfiles library was updated to support this new mapping as described in this [talk](https://www.youtube.com/watch?v=5NbgUMH1OGo). Since rules_swift supports both Bazel 5 and 6, we need to check `BAZEL_CURRENT_REPOSITORY` is defined to simply make use of the new constructor which will make it so the runfiles lookup will happen relative to the `rules_swift` repo under Bazel 6. I tested this locally with a `local_path_override` while iterating on getting the `rules_xcodeproj` to work under bzlmod (and also continues to work with bzlmod disabled in Bazel 6): MobileNativeFoundation/rules_xcodeproj#1502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Swift code with
--enable_bzlmod, it currently fails due to the worker failing to find theindex-importexecutable in the runfiles. This is because the naming is different under bzlmod and the C++ runfiles library was updated to support this new mapping as described in this talk. Since rules_swift supports both Bazel 5 and 6, we need to checkBAZEL_CURRENT_REPOSITORYis defined to simply make use of the new constructor which will make it so the runfiles lookup will happen relative to therules_swiftrepo under Bazel 6.I tested this locally with a
local_path_overridewhile iterating on getting therules_xcodeprojto work under bzlmod (and also continues to work with bzlmod disabled in Bazel 6): MobileNativeFoundation/rules_xcodeproj#1502