Fix sanitizers on Linux #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a feature name doesn't start with `swift.` we check if it's enabled by checking against the C++ features, not against all features. Previously the Linux CC toolchain didn't support sanitizers so these just never worked on Linux and the features were silently ignored from Swift. Today these features were added to the Linux CC toolchain bazelbuild/bazel@abae5ca which broke Linux CI because ubsan doesn't work with Swift on Linux and asan fails because of a memory leak in Swift
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins and
thii
as code owners
brentleyjones
approved these changes
Jan 11, 2023
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
When a feature name doesn't start with `swift.` we check if it's enabled by checking against the C++ features, not against all features. Previously the Linux CC toolchain didn't support sanitizers so these just never worked on Linux and the features were silently ignored from Swift. Today these features were added to the Linux CC toolchain bazelbuild/bazel@abae5ca which broke Linux CI because ubsan doesn't work with Swift on Linux and asan fails because of a memory leak in Swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a feature name doesn't start with
swift.we check if it's enabledby checking against the C++ features, not against all features.
Previously the Linux CC toolchain didn't support sanitizers so these
just never worked on Linux and the features were silently ignored from
Swift. Today these features were added to the Linux CC toolchain
bazelbuild/bazel@abae5ca
which broke Linux CI because ubsan doesn't work with Swift on Linux and
asan fails because of a memory leak in Swift