Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tuple to collection subjects #69

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Oct 2, 2023

tuples are as list-like or more than depsets, but previously resulted in a fail when passed to collection subject functions.

Along the way remove an incorrect comment about str being iterable, which it is in Python but not in Starlark.

`tuple`s are as list-like or more than `depset`s, but previously
resulted in a `fail` when passed to collection subject functions.

Along the way remove an incorrect comment about `str` being iterable,
which it is in Python but not in Starlark.
@fmeum
Copy link
Contributor Author

fmeum commented Oct 2, 2023

@rickeylev CI is failing and I can't access the buildkite logs, but tests are passing locally.

@comius
Copy link
Collaborator

comius commented Oct 2, 2023

@rickeylev CI is failing and I can't access the buildkite logs, but tests are passing locally.



##### :bazel: buildifier: found 8 lint issues in your WORKSPACE, BUILD and *.bzl files
--
  | <pre><code><a href="https://github.com/fmeum/rules_testing/blob/c0631c8a8388bd1948ff7c679e6fdce917d00889/docgen/docgen.bzl#L18">docgen/docgen.bzl:18:1</a>: <a href="https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#out-of-order-load">out-of-order-load</a>: Load statement is out of its lexicographical order.
  | <a href="https://github.com/fmeum/rules_testing/blob/c0631c8a8388bd1948ff7c679e6fdce917d00889/lib/private/default_info_subject.bzl#L18">lib/private/default_info_subject.bzl:18:1</a>: <a href="https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#out-of-order-load">out-of-order-load</a>: Load statement is out of its lexicographical order.
  | <a href="https://github.com/fmeum/rules_testing/blob/c0631c8a8388bd1948ff7c679e6fdce917d00889/lib/test_suite.bzl#L7">lib/test_suite.bzl:7:1</a>: <a href="https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#out-of-order-load">out-of-order-load</a>: Load statement is out of its lexicographical order.
  | <a href="https://github.com/fmeum/rules_testing/blob/c0631c8a8388bd1948ff7c679e6fdce917d00889/lib/truth.bzl#L57">lib/truth.bzl:57:1</a>: <a href="https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#out-of-order-load">out-of-order-load</a>: Load statement is out of its lexicographical order.
  | <a href="https://github.com/fmeum/rules_testing/blob/c0631c8a8388bd1948ff7c679e6fdce917d00889/tests/struct_subject/struct_subject_tests.bzl#L18">tests/struct_subject/struct_subject_tests.bzl:18:1</a>: <a href="https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#out-of-order-load">out-of-order-load</a>: Load statement is out of its lexicographical order.
  | <a href="https://github.com/fmeum/rules_testing/blob/c0631c8a8388bd1948ff7c679e6fdce917d00889/tests/test_util.bzl#L19">tests/test_util.bzl:19:1</a>: <a href="https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#out-of-order-load">out-of-order-load</a>: Load statement is out of its lexicographical order.
  | <a href="https://github.com/fmeum/rules_testing/blob/c0631c8a8388bd1948ff7c679e6fdce917d00889/tests/truth_tests.bzl#L19">tests/truth_tests.bzl:19:1</a>: <a href="https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#out-of-order-load">out-of-order-load</a>: Load statement is out of its lexicographical order.
  | <a href="https://github.com/fmeum/rules_testing/blob/c0631c8a8388bd1948ff7c679e6fdce917d00889/tests/unit_test_tests.bzl#L4">tests/unit_test_tests.bzl:4:1</a>: <a href="https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#out-of-order-load">out-of-order-load</a>: Load statement is out of its lexicographical order.</pre></code>

@fmeum
Copy link
Contributor Author

fmeum commented Oct 2, 2023

@comius Thanks, got it to pass by fixing the (unrelated) failures.

Copy link
Contributor

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update CHANGELOG.md? Otherwise lgtm

@rickeylev rickeylev added enhancement New feature or request ready to pull Required label for automatic import to Google labels Oct 3, 2023
@copybara-service copybara-service bot merged commit 5bfa721 into bazelbuild:master Oct 4, 2023
4 of 5 checks passed
@fmeum fmeum deleted the tuple branch October 4, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to pull Required label for automatic import to Google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants