-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tuple
to collection subjects
#69
Conversation
`tuple`s are as list-like or more than `depset`s, but previously resulted in a `fail` when passed to collection subject functions. Along the way remove an incorrect comment about `str` being iterable, which it is in Python but not in Starlark.
@rickeylev CI is failing and I can't access the buildkite logs, but tests are passing locally. |
|
@comius Thanks, got it to pass by fixing the (unrelated) failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update CHANGELOG.md? Otherwise lgtm
tuple
s are as list-like or more thandepset
s, but previously resulted in afail
when passed to collection subject functions.Along the way remove an incorrect comment about
str
being iterable, which it is in Python but not in Starlark.