Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Remove --incompatible_depset_is_not_iterable #471

Closed

Conversation

laszlocsomor
Copy link
Contributor

Remove this flag from the .bazelrc.

Bazel no longer supports this flag, see bazelbuild/bazel#5816

Attention Googlers: This repo has its Source of Truth in Piper. After sending a PR, you can follow http://g3doc/third_party/bazel_rules/rules_typescript/README.google.md#merging-changes to get your change merged.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Using Bazel built from bazelbuild/bazel@8f075d2, bazel-head info breaks. Culprit is Bazel no longer supports --incompatible_depset_is_not_iterable, added here:

build --incompatible_depset_is_not_iterable

Issue Number: N/A

Did not open any issue, because the bug template asks to open issues with rules_nodejs, but the bug is specific to this repo.

What is the new behavior?

bazel-head info works.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Remove this flag from the .bazelrc.

Bazel no longer supports this flag, see bazelbuild/bazel#5816
@laszlocsomor laszlocsomor marked this pull request as ready for review November 26, 2019 12:59
@laszlocsomor
Copy link
Contributor Author

@alexeagle
Copy link
Contributor

merged as e9b2131

@alexeagle alexeagle closed this Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants