Support windows

[alexeagle]

At least half the Angular ecosystem runs on Windows machines.

currently trying the simple python example from the README I get

ERROR: C:/users/angular/appdata/local/temp/_bazel_angular/zyn_1rhm/external/io_bazel_rules_webtesting/browsers/BUILD:67:
1: Configurable attribute "environment" doesn't match this configuration (would a default condition help?).
Conditions checked:
 @io_bazel_rules_webtesting//browsers:linux
 @io_bazel_rules_webtesting//browsers:mac.
ERROR: Analysis of target '//:browser_test_chromium-native' failed; build aborted.

[joshbruning]

Native Windows support is currently scheduled for Q4, but we have a Windows machine on which to perform the work, and there are no blockers. Is resolution in October sufficient, or do you need something this month?

[alexeagle]

That's fine, I don't support Windows with the typescript rules yet either.

…

On Fri, Sep 8, 2017 at 5:11 PM Joshua Bruning ***@***.***> wrote: Native Windows support is currently scheduled for Q4, but we have a Windows machine on which to perform the work, and there are no blockers. Is resolution in October sufficient, or do you need something this month? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#178 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC5Iys_qV1hBl1kSxnjkf-7snDfzF3iks5sgdfLgaJpZM4PRznw> .

[joshbruning]

My PR will resolve many of the issues; a fix to bazelbuild/rules_go#736 should resolve remaining known issues. (Then the ball will be back in our court.)

[filipesilva]

As far as I can tell, #293 removed all Windows related configurations introduced in #179.

Are these expected to be re-introduced?

[alexeagle]

Even if users are required to define their own browser configurations, it still seems there is no such configuration that works with these rules on Windows.

[joshbruning]

A fix for bazelbuild/rules_go#1619 was made about a month ago. We can try to update our version of rules_go and see what the next blocker is; Marc had only removed Windows configurations as they weren't working anyway.

[joshbruning]

After the most recent rules_go update, core Go components seem to build fine (!), but the browser configurations are getting stuck on web/internal/extract.sh - need to make this Windows compatible, I think (so long as I'm reading the errors correctly).

[filipesilva]

@joshbruning I think I saw that error in #284 (comment) when I was trying to define my own browsers, as well as use the provided ones.

[filipesilva]

Heya just wanted to mention I tried the latest master and Chrome does run on Windows. Cheers!

[filipesilva]

There seems to be some issue with Chrome 88+ on Windows Server:

• https://stackoverflow.com/questions/51860091/does-chromium-headless-work-on-windows-server-core-2016
• https://bugs.chromium.org/p/chromium/issues/detail?id=873097

In our case the tests pass locally but not on our Windows CI: https://source.cloud.google.com/results/invocations/17e1620a-df58-430b-bbad-49dfbef6332e/targets/%2F%2Fexamples%2Ftesting:testing_chromium-local/log

[joshbruning]

(Chrome 88+ -> Chrome 68+)

We validated on "Windows Server 2016 Datacenter".

66.0.3359.181 has branch base position: 540276. 540270 is the closest I see in chromium-browser-snapshots. In web/repositories.bzl, you can put Chromium/Windows back on 540270 (and update sha).

You'll also probably want to put chromedriver/Windows back on 2.38:
https://chromedriver.storage.googleapis.com/2.38/chromedriver_win32.zip

If you send me a pull request, I'll merge it; otherwise, let me know if you just want me to do it when I have a spare cycle.

[filipesilva]

@joshbruning thanks for the guidance, I put a PR up at #303