Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing #352

Closed
laurentlb opened this issue May 17, 2019 · 4 comments
Closed

Tests are failing #352

laurentlb opened this issue May 17, 2019 · 4 comments

Comments

@laurentlb
Copy link

According to Bazel CI, rules_webstesting doesn't work with Bazel flag --incompatible_depset_is_not_iterable:

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/110#f5e4c0cc-36b5-44b2-80fe-9b3ead98c239

Can you take a look?

@laurentlb
Copy link
Author

I cannot reproduce locally. Our CI ran the tests at commit 24771d4, which is old. This probably happens because tests are failing.

@laurentlb laurentlb changed the title incompatible_depset_is_not_iterable Tests are failing May 23, 2019
@laurentlb
Copy link
Author

$ bazel build --nobuild ...
Starting local Bazel server and connecting to it...
ERROR: /.../laurentlb/rules_webtesting/go/metadata/BUILD.bazel:21:1: in go_library rule //go/metadata:go_default_library: non-test target '//go/metadata:go_default_library' depends on testonly target '//go/bazel:go_default_library' and doesn't have testonly attribute set
ERROR: /.../laurentlb/rules_webtesting/go/metadata/BUILD.bazel:21:1: in go_library rule //go/metadata:go_default_library: non-test target '//go/metadata:go_default_library' depends on testonly target '//go/metadata/capabilities:go_default_library' and doesn't have testonly attribute set
ERROR: Analysis of target '//testdata:https' failed; build aborted: Analysis of target '//go/metadata:go_default_library' failed; build aborted

joshbruning added a commit that referenced this issue May 23, 2019
Remove testonly #352
joshbruning added a commit that referenced this issue May 23, 2019
Remove testonly #352
@hlopko
Copy link
Member

hlopko commented May 27, 2019

Hi @joshbruning, thanks for these fixes! It seems it didn't help though :( https://buildkite.com/bazel/rules-webtesting-saucelabs/builds/119#7453627d-1941-4eb3-88ee-0d696ac14f00

joshbruning added a commit that referenced this issue May 27, 2019
See errors in #352.
mtrea pushed a commit that referenced this issue May 28, 2019
@DrMarcII
Copy link
Contributor

Fixed as of PR #358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants