Hide commands intended as command variables #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commands `bazel.info.*` and `bazel.getOutputPath` are intended to be used as command variables within `launch.json` and `task.json`. For additional context, see bazelbuild#273, bazelbuild#275 and bazelbuild#291. Those commands are not intended to be called by users directly. As such, they should not show up in the command palette. Calling them from the command picker has no user-visible effect and leaves the user with the impression that those commands would be broken. This commit removes them from the `commands` contribution point, thereby hiding them from the command picker. To make sure that the extension is loaded as soon as some `task.json`/`launch.json` invokes any of those commands, they now need to be registered as `activationEvents`, since VS Code will no longer discover those events automatically from the `commands` contributions.
vogelsgesang
requested review from
coeuvre,
jfirebaugh and
cameron-martin
as code owners
cameron-martin
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commands
bazel.info.*andbazel.getOutputPathare intended to be used as command variables withinlaunch.jsonandtask.json. For additional context, see #273, #275 and #291.Those commands are not intended to be called by users directly. As such, they should not show up in the command palette. Calling them from the command picker has no user-visible effect and leaves the user with the impression that those commands would be broken.
This commit removes them from the
commandscontribution point, thereby hiding them from the command picker. To make sure that the extension is loaded as soon as sometask.json/launch.jsoninvokes any of those commands, they now need to be registered asactivationEvents, since VS Code will no longer discover those events automatically from thecommandscontributions.BEGIN_COMMIT_OVERRIDE
fix: Hide commands which are intended to be command variables (#347)
END_COMMIT_OVERRIDE