Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce pickTarget and pickPackage command variables #354

Merged
merged 2 commits into from
Apr 2, 2024
Merged

feat: Introduce pickTarget and pickPackage command variables #354

merged 2 commits into from
Apr 2, 2024

Commits on Apr 2, 2024

  1. Introduce pickTarget and pickPackage command variables 

    This commit introduces the `bazel.pickTarget` and `bazel.pickPackage`
command variables. Those commands can be used from `tasks.json` and
`launch.json` to prompt the user to select a Bazel target or package.
The available choices are determined by a user-specified Bazel query.

The implementation reuses the existing quick-pick functionality from
`bazel_quickpick.ts`. The `wrapQuickPick` function parses the arguments
passed from the `task.json` and then forwards to the existing quickpicks.

Those utility functions were restructured as part of this commit:
1. The internal helpers `queryWorkspaceQuickPickPackages` and
   `queryWorkspaceQuickPickTargets` were inlined into
   `queryQuickPick{Packages,Targets}` as the internal helper functions
   got in the way of other changes, but didn't deduplicate any code as
   they only had one caller.
2. The `queryQuickPick{Packages,Targets}` take an object with named
   parameters now.
3. `queryQuickPickPackage` now also accepts a `query` parameter instead
   of using the `queryExpression`. Both `queryQuickPickPackages` and
   `queryQuickPickTargets` default to the query `//...` if no query
   string is provided by the caller.

Point (3) also is a user-facing change. Commands like "Build package" and
"Test package" now use `//...` instead of the configured `queryExpression`.
This is in sync with other commands like "Test target" which uses the
hardcoded query `kind('.*_test rule', ...)`.
    @vogelsgesang
    vogelsgesang committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1fc4fc4 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @vogelsgesang
    vogelsgesang committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    eaf2a04 View commit details
    Browse the repository at this point in the history