Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't wait on the "Buildifier not found" notification #368

Merged
merged 1 commit into from
Apr 6, 2024
Merged

fix: Don't wait on the "Buildifier not found" notification #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/extension/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,12 @@ export async function activate(context: vscode.ExtensionContext) {

// Notify the user if buildifier is not available on their path (or where
// their settings expect it).
// eslint-disable-next-line @typescript-eslint/no-floating-promises
await checkBuildifierIsAvailable();
// We intentionally do no `await` the completion because doing so would mean
// that VS Code considers the extension activation to be "in-flight" until the
// users closes the "Buildifier not found" notification. VS Code hence
// dislayed never-finishing "Loading" indicator on top of the "Bazel Build
// Targets" tree view.
checkBuildifierIsAvailable();
}

/** Called when the extension is deactivated. */
Expand Down