Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace native.maven_jar with function that respects HTTP_PROXY #9

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Replace native.maven_jar with function that respects HTTP_PROXY #9

merged 1 commit into from
Apr 2, 2019

Conversation

beala-stripe
Copy link
Contributor

native.maven_jar doesn't respect the environment variable HTTP_PROXY. This replaces the call to native.maven_jar with jvm_maven_import_external, which does respect HTTP_PROXY.

johnynek
johnynek approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnynek johnynek merged commit 334e241 into bazeltools:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnynek johnynek johnynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beala-stripe @johnynek