Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site detection faulty #155

Closed
ocstaron opened this issue Mar 7, 2022 · 2 comments
Closed

Site detection faulty #155

ocstaron opened this issue Mar 7, 2022 · 2 comments
Labels
bug Something isn't working
Milestone
1.2.3

Comments

@ocstaron
Copy link

ocstaron commented Mar 7, 2022

Please correct module/sources/common/source_base.py

Line 266 should be

site_name = grab(device_object, "data.site.name")

instead of

site_name = grab(device_object, "data.site.data.name")

After this fix, site VRF and Tenant detection works again.

Kind regards and thanks,
Oliver
bb-Ricardo added a commit that referenced this issue Mar 29, 2022
@bb-Ricardo
fixes faulty site name detection on interface parsing #155
b742279
@bb-Ricardo bb-Ricardo added this to the 1.2.3 milestone Mar 29, 2022
@bb-Ricardo
Copy link
Owner

Hi Oliver,

Thank you for this great hint. This is was indeed a bug. It should be fixed now: b742279

Can you check out the branch 'development' and see if it works for you? That would be great.

@bb-Ricardo bb-Ricardo added the bug Something isn't working label Mar 29, 2022
@bb-Ricardo
Copy link
Owner

fixed in version 1.2.3

dupondje pushed a commit to dupondje/netbox-sync that referenced this issue May 5, 2022
@bb-Ricardo @dupondje
fixes faulty site name detection on interface parsing bb-Ricardo#155
f5a7d58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.3
Development

No branches or pull requests
2 participants
@bb-Ricardo @ocstaron