Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone currently does not take into account Daylight savings time #276

Open
evanmalmud opened this issue Mar 15, 2023 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@evanmalmud
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When putting in a timezone in the configuration of "EST" once we swap times to EDT it would require a configuration change to keep producing notifications at the same time.

For instance a week ago this would produce notifications at 8am ET

config:
      timezone: "EST"
      schedule: "0 0 8 ? * MON-FRI"

But now notifications are produced at 9am ET

Describe the solution you'd like
Instead of using EST or EDT timezone instead use the Java Zone.id so a user can add
Americas/NewYork and the timezone will always match ET.
https://docs.oracle.com/javase/8/docs/api/java/time/ZoneId.html
A list of options is available on that page.

Describe alternatives you've considered
Some sort of boolean to support Daylight shift? Might be hard to know when DT is active.

Additional context
N/a

@evanmalmud evanmalmud added the enhancement New feature or request label Mar 15, 2023
@bbaga
Copy link
Owner

bbaga commented Mar 15, 2023

Thank you for the report. This is a (sadly) known issue, that needs further investigation as EST/EDT/ET never worked properly, even though the Quartz's documentation makes claims that they should be observed. If I remember correctly, time zone names such as Americas/NewYork are supported already, but the issue with DST remains.

Since Quartz may be abandoned at this point the job scheduler may have to be replaced anyway.

@bbaga
Copy link
Owner

bbaga commented Apr 7, 2023

Hey @evanmalmud, have you had a chance to try the zone id format in the configuration file?

@evanmalmud
Copy link
Contributor Author

evanmalmud commented Apr 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants