Skip to content

Commit

Permalink
Addressed all review feedback and TODOs for KeySamplerCLI
Browse files Browse the repository at this point in the history
KeySamplerCLI
- added options: --store-names, --partition-ids, --keys-per-second-limit, and --progress-period-ops
- got rid of unnecessary (and weird) retry loop. Can add seomthing like that later if needed.
- pass all partitions to fetcher now instead of one-at-a-time

Also did cosmetic fixes for KeyVersionSamplerCLI and Entropy.java
  • Loading branch information
jayjwylie committed Mar 20, 2013
1 parent 96d1513 commit f5e8f5a
Show file tree
Hide file tree
Showing 3 changed files with 197 additions and 110 deletions.
5 changes: 3 additions & 2 deletions src/java/voldemort/utils/Entropy.java
Expand Up @@ -48,8 +48,9 @@
import com.google.common.base.Joiner;
import com.google.common.collect.Maps;

// Entropy is replaced by KeySamplerCLI and KeyVersionFetcherCLI. Entropy never
// really worked as described and had a complicated interface.
// TODO: Remove from the code base.
// Entropy is replaced by KeySamplerCLI and KeyVersionFetcherCLI. Entropy
// never really worked as described and had a complicated interface.
@Deprecated
public class Entropy {

Expand Down

0 comments on commit f5e8f5a

Please sign in to comment.