Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify 3.0 #73

Merged
merged 14 commits into from
May 4, 2022
Merged

Verify 3.0 #73

merged 14 commits into from
May 4, 2022

Conversation

bbatsche
Copy link
Owner

Major refactor & improvements for Verify 3.0

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #73 (511ab30) into master (463dfbc) will decrease coverage by 7.40%.
The diff coverage is 91.35%.

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     98.77%   91.37%   -7.41%     
+ Complexity      295      200      -95     
============================================
  Files             7        6       -1     
  Lines           652      452     -200     
============================================
- Hits            644      413     -231     
- Misses            8       39      +31     
Impacted Files Coverage Δ
src/API/File.php 87.69% <87.69%> (ø)
src/Constraint/Factory.php 87.80% <87.80%> (ø)
src/API/Base.php 93.70% <93.70%> (ø)
src/API/Value.php 93.98% <93.98%> (ø)
src/Exception/MissingConditionException.php 100.00% <100.00%> (ø)
src/function.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 463dfbc...511ab30. Read the comment docs.

@bbatsche
Copy link
Owner Author

Knew there would be a hit to code coverage with these changes and we’re ok with that; 86% is better than I was afraid it would be. Still, there are a few edge cases in the codecov report that I think we could cover reasonably. I think 90% might be feasible.

@bbatsche bbatsche merged commit b01bd15 into master May 4, 2022
@bbatsche bbatsche deleted the assert-constraint branch May 4, 2022 20:24
@bbatsche bbatsche linked an issue May 5, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant