-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify 3.0 #73
Verify 3.0 #73
Conversation
PHPUnit 9 specific tests Fix IsEqual constructor of PHPUnit 8
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
============================================
- Coverage 98.77% 91.37% -7.41%
+ Complexity 295 200 -95
============================================
Files 7 6 -1
Lines 652 452 -200
============================================
- Hits 644 413 -231
- Misses 8 39 +31
Continue to review full report at Codecov.
|
Knew there would be a hit to code coverage with these changes and we’re ok with that; 86% is better than I was afraid it would be. Still, there are a few edge cases in the codecov report that I think we could cover reasonably. I think 90% might be feasible. |
Major refactor & improvements for Verify 3.0