New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust crux-copy-file-preserve-attributes #100

Merged

bbatsov merged 1 commit into bbatsov:master from fredericgiquel:rewrite-copy-file-preserve-attributes

Feb 23, 2024

Contributor

fredericgiquel commented Jan 3, 2024

crux-copy-file-preserve-attributes suffers from several problems:

A new buffer is always opened without correctly taking into account the value of universal argument
If filename is different, the new opened buffer contains the source file (destination file in same directory) or an empty buffer (destination file in other directory)
If the destination chosen by user is a complete path (with filename) in a non-existent directory, the function fails with error "Opening output file: No such file or directory"

So I rewrote the function in a more robust way to to limit mishandled cases.


          More robust crux-copy-file-preserve-attributes

03df928

bbatsov merged commit df476a7 into bbatsov:master

Owner

bbatsov commented Feb 23, 2024

Thanks and sorry for the slow response!

fredericgiquel mentioned this pull request

Create nonexistent parent directories in crux-copy-file-preserve-attributes #102

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment