Use beginning-of-visual-line' in move-to-mode-line-start'
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the super slow response! I agree with the spirit of the change, but I think it's going to be pretty confusing to change the current behavior with with 3) happening before 2). We might have to stomach a bit of extra complexity. :-) |
|
Ok, no worries 😉 You can close this PR for now and maybe we can figure out something on this regard. Thanks! |
|
@mssola I've been thinking it's probably best to just add a defcustom controlling which variant to use. This way we keep to code simple and cover both cases. |
|
Good point. I can work on that whenever I have some spare time. |
|
Thanks! |
In some environments users expect crux's functions to respect visual lines. This can now be configured through the `crux-should-move-visually' configurable variable. If set to true, then `move-to-mode-line-start' will use take into account visual lines. Otherwise (the default behavior), it will work as usual by moving to the logical beginning of the line. For functions like `crux-move-beginning-of-line', specifically, the user will face the following situation when setting `crux-should-move-visually; to true: 1. If the user runs this function in the middle of a visual line, it will go to the beginning of said visual line. 2. If the user runs this function again, then it will go to the beginning of the real line. 3. If the user runs this function again, then it will go to the first non-space character of the line. Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola
force-pushed
the
beginning-of-visual-line
branch
from
2f90963
to
e391262
Compare
|
@bbatsov done. Sorry for taking so long... |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, functions such as `crux-move-beginning-of-line' work as expected when in visual-line mode:
Swapping 2 and 3 may also be an expected behavior but then the code became way more complicated than it should.
Signed-off-by: Miquel Sabaté Solà msabate@suse.com