Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crux-recentf-find-directory #78

Merged
merged 1 commit into from Feb 24, 2021
Merged

Add crux-recentf-find-directory #78

merged 1 commit into from Feb 24, 2021

Conversation

mpolden
Copy link
Contributor

@mpolden mpolden commented Feb 23, 2021

Adds crux-recentf-find-directory for opening recent directories. Complements the existing crux-recentf-find-file.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

crux.el Outdated Show resolved Hide resolved
@@ -606,17 +606,25 @@ as the current user."
(insert (format-time-string "%c" (current-time))))

;;;###autoload
(defun crux-recentf-find-file ()
"Find a recent file using `completing-read'."
(defun crux-recentf-find-file (&optional filter)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively you can make this some private helper function and have a single command be used for files and directories depending on whether it was used with a prefix argument (e.g. C-u C-c f). I don't have a strong preference either way, though - just something that came to my mind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference either. Your call 🙂

@bbatsov bbatsov merged commit a471cbe into bbatsov:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants