Use derived-mode-p
for functions to also work for derived modes
#92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case I recently started using
dirvish
, which is an enhanced dired-mode, and I was surprised thatcrux-open-with
didn't work, but I fixed it by usingderived-mode-p
.Then, I searched for other occurrences of
major-mode
and also replaced thereby
I'm still not sure whether I should also do that in
crux-cleanup-buffer-or-region
, where in checking the membership incrux-untabify-sensitive-modes
andcrux-indent-sensitive-modes
, derived modes are note considered. These variables are customizable and I think not considering derived modes there adds control. But here I would be happy on feedback.M-x checkdoc
warnings