Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #902] Fix kill-region advice function #903

Closed
wants to merge 1 commit into from

Conversation

vamega
Copy link

@vamega vamega commented Sep 8, 2015

Prevent the advice function from causing errors when rectangle-mark-mode
is not activated.

Prevent the advice function from causing errors when rectangle-mark-mode
is not activated.
@toctan
Copy link
Contributor

toctan commented Sep 8, 2015

rectangle-mark-mode is an interactive autoloaded compiled Lisp
function in `rect.el'.

It is bound to C-x SPC.

(rectangle-mark-mode &optional ARG)

Toggle the region as rectangular.
Activates the region if needed. Only lasts until the region is deactivated.

This definitely does not fix the problem. Every time kill-region gets called, it's going to toggle the activated region as rectangular, in effect, every kill would become rectangle kill.

@vamega
Copy link
Author

vamega commented Sep 8, 2015

That may be the case. I'll check when I get home today.

@vamega
Copy link
Author

vamega commented Sep 9, 2015

@toctan is completely right. This breaks kill-region by always making it behave as if it's in rectangel-mark-mode. Will attempt to fix correctly later.

@bbatsov bbatsov closed this Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants