Grep searches ignored directories on OS X

[bosko]

Directories listed in the .projectile file are searched when "Find in project" command is executed and they should be ignored.

[mbezjak]

I can confirm this on Arch Linux as well.

The problem is because projectile-ignored-directories contain absolute paths when they should be relative to the current working directory. Here is what man find says about it:

Note  that  the  pattern  match test applies to the whole file name, starting from one of the
start points named on the command line.  It would only make sense to  use  an  absolute  path
name here if the relevant start point is also an absolute path.  This means that this command
will never match anything:
         find bar -path /foo/bar/myfile -print

Therefore when setting up grep-find-ignored-directories, projectile-ignored-directories should be relative to root-dir.

[mbezjak]

Here is a quick and dirty fix that works for me

...
(let* ((ignored-directories (mapcar (lambda (d) (replace-regexp-in-string "/$" "" (file-relative-name d root-dir))) (projectile-ignored-directories)))
       (grep-find-ignored-directories (append ignored-directories grep-find-ignored-directories)))
...)

[ignacy]

Here's a way to fix it without changing projectile. This still needs to be fixed - but untill it is, it's easier (for me) to just add files/directories to global grep ignored list, like that:

(eval-after-load "grep"
  '(progn
     (add-to-list 'grep-find-ignored-directories ".bundle")
     (add-to-list 'grep-find-ignored-directories "log")))

[bbatsov]

I've recently done some changes that should have taken care of that particular problem. Is it still present?

[mbezjak]

I'm using 0.8 and it has indeed been fixed on Linux.

[bbatsov]

And I'm using OSX and I know it's fixed there. :-)

[bosko]

Strange. I'm using OSX and directories listed in .projectile file are still not ignored by grep. I just upgraded package thorough package manager to the version 20130129.2335. Is this version the one that has this fix?

[mbezjak]

It worked for me when I added leading forward slash (/) to every line. That is documented in readme: https://github.com/bbatsov/projectile#ignoring-files

I haven't tried relative pathnames, though.

[bosko]

I knew I made an error :) It is working with leading slash. I tried with ending slash which I thought will notify projectile that it is directory that's why it didn't work. However I think using forward slashes (without relative paths) results in a little bit strange syntax since /log associates to top level file system directory rather than subdirectory of current project. Nevertheless it is working now. Excellent!

[bbatsov]

It's a work in progress. Luckily we're making progress (albeit slowly). :-)

[bosko]

Excellent work I must say. Just keep going. It would be good if it can accept relative paths because current ignore list looks quite strange if there are hidden directories. For example ./bundle directory in ignore list must be written as /.bundle. Thanks again for this fix ;-)