Use lexical binding as default #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll also have to add a dependency on Emacs 24 in the packages header. |
The `recompile` command won't work since the definitions of `file-name` in `rubocop--file-command` (line 122) and `directory` in `rubocop--dir-command` (line 86) won't be available in the lambdas given to the `compilation-start` function. By adding lexical binding as a default option for the file, the problem is seamlessly solved.
|
Nice, didn't know that. I've added the requirement in the package header. |
|
Is the PR ok now ? |
bbatsov
added a commit
that referenced
this pull request
Dec 21, 2014
Use lexical binding as default
|
Yes. Sorry about the delayed response. |
|
No problem ;) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
recompilecommand won't work since the definitions offile-namein
rubocop--file-command(line 122) anddirectoryinrubocop--dir-command(line 86) won't be available in the lambdas givento the
compilation-startfunction, since Emacs does not use lexical scope bydefault.
By adding lexical binding as a default option for the file, the problem
is seamlessly solved (apparently).
Although I can sort of
recompileby repeating the rubocop command with theprovided keybindings, I rather have the ability to just press g in
the compilation buffer or use my custom recompile binding.