Merge pull request #2391 from alexdowad/replace_fix

[Fix #2390] `Performance/StringReplacement` doesn't convert `gsub(/./, ...)` to `tr`
rubocop · Nov 3, 2015 · dd4c1ea · dd4c1ea
2 parents 63e0be5 + 7f2d271
commit dd4c1ea
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rubocop/cop/performance/string_replacement.rb b/lib/rubocop/cop/performance/string_replacement.rb
@@ -20,7 +20,7 @@ module Performance
       #   'a b c'.delete(' ')
       class StringReplacement < Cop
         MSG = 'Use `%s` instead of `%s`.'
-        DETERMINISTIC_REGEX = /^[\w\s\-,."']+$/.freeze
+        DETERMINISTIC_REGEX = /^[\w\s\-,"']+$/.freeze
         REGEXP_CONSTRUCTOR_METHODS = [:new, :compile].freeze
         GSUB_METHODS = [:gsub, :gsub!].freeze
         DETERMINISTIC_TYPES = [:regexp, :str, :send].freeze

diff --git a/spec/rubocop/cop/performance/string_replacement_spec.rb b/spec/rubocop/cop/performance/string_replacement_spec.rb
@@ -244,6 +244,12 @@
       expect(cop.messages).to be_empty
     end
 
+    it 'allows regex containing a .' do
+      inspect_source(cop, %('abc'.gsub(/./, 'a')))
+
+      expect(cop.messages).to be_empty
+    end
+
     it 'allows regex containing a |' do
       inspect_source(cop, %('abc'.gsub(/a|b/, 'd')))