Exclude not working as expected

[mockdeep]

I'm trying to exclude a bunch of files from the HashSyntax cop and running into some issues. My config looks like this:

HashSyntax:
  Exclude:
    - app/views/**/*
    - app/controllers/**/*
    - app/helpers/**/*
    - app/mailers/**/*
    - app/models/**/*
    - app/poros/**/*
    - spec/**/*

When I run rubocop with these settings, I'm getting some really erratic behavior. Right now it is reporting every violation everywhere, without regard to the excludes. I was running it with rubocop -a and it would report back that 130 or so violations were fixed, when in fact it had fixed every violation in the app, again without regard to the excludes. I can't seem to get back to that state now, though. I've been trying some different patterns and getting different results.

[jonas054]

Which version of RuboCop are you running? It looks to me like you're following the instruction from the README file on the main page, which refers to the latest master. That won't work together with the relased versions (currently 0.20.1), since they use File.fnmatch to match paths. For example, app/views/**/* will not match app/views/file.rb.

Use .../** instead of .../**/* until next release.

[mockdeep]

@jonas054 Yeah, I'm on 0.20.1. I also tried .../** but without success. It returned about 25% fewer violations, but we have thousands, so I was unable to figure out which ones it skipped. It did still return a lot from the directories I wanted to exclude.

[jonas054]

@mockdeep If you run with --only HashSyntax, you should be able to see if you get any reports in the files you want to exclude or not.

[mockdeep]

@jonas054 That doesn't seem to respect .rubocop.yml at all. When I have the rule disabled, running rubocop globally works fine, but running it with --only HashSyntax reports 1637 violations.

[mockdeep]

When I set Exclude: it finds the appropriate number of violations. When I run rubocop --only HashSyntax -a, it reports that it only fixed 16 violations, which is to be expected, but really it went through and fixed all of them, including in the files that were excluded.

[jonas054]

@mockdeep If you meant that you disabled HashSyntax by setting Enabled: false for it in a configuration file, then the --only HashSyntax will enable the cop. That's by design.

But the other thing you found is a bug IMO. Auto-correct does not respect Exclude settings. I've been able to reproduce this problem.