Track usage of every assignment in UnusedLocalVariable #469
+3,587
−1,577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I vote for option 2 as well. |
Also rename VariableEntry to Variable.
The cop now tracks usage of each assignment rather than usage in entire variable lifetime. This closes #458.
* Extracted useless setter call tracking part of UselessAssignment to UselessSetterCall. * Renamed UnusedLocalVariable to UselessAssignment.
|
Pushed additional commit for option 2. |
bbatsov
added a commit
that referenced
this pull request
Sep 9, 2013
Track usage of every assignment in UnusedLocalVariable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #458.
It was much more complex than I expected, but I think I've done. :)
UnusedLocalVariablenow tracks usage of every assignment, that is neither entire variable lifetime nor only last assignment.Before merging, I think we should consider reorganizing the new
UnusedLocalVariableandUselessAssignment.UnusedLocalVariableis now superior toUselessAssignment.UnusedLocalVariabletracks every useless assignment in every scope.UselessAssignmenttracks useless assignment at the end of method.UselessAssignmentalso tracks useless setter call at the end of method (technically it's not assignment though).I think there are two choices:
UselessAssignment. Two different logics, the newUnusedLocalVariable's one and the setter call tracking part of the currentUselessAssignment, would live in a cop.UselessSetterCall(or something), and renameUnusedLocalVariabletoUselessAssignment.I'd prefer option 2.