Static length #2276
Merged
Static length #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrosenblum
force-pushed
the
static_length
branch
from
6e79f72
to
f9bae17
Compare
|
I am fine with making it a Performance cop. I initially wrote it as a performance cop, but I wasn't sure if it had enough of a performance impact to be considered a performance cop or not. |
rrosenblum
force-pushed
the
static_length
branch
10 times, most recently
from
902f11f
to
942b6c9
Compare
|
I like the cop, but I don't like the name, as static is often used in programming with other meaning. Perhaps |
|
I like your suggestion about the name change. I am leaning towards |
rrosenblum
force-pushed
the
static_length
branch
4 times, most recently
from
57ef6c0
to
891a166
Compare
rrosenblum
force-pushed
the
static_length
branch
from
891a166
to
913aae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a number of places in the codebase that call
sizeon a string literal. I recognize that sometimes this seems better than using a magic variable, so I am allowing it in constants.The failing tests will be fixed by #2274.