Allow %Q for dynamic strings with double quotes inside
#2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| * [#2413](https://github.com/bbatsov/rubocop/issues/2413): Allow `%Q` for dynamic strings with double quotes inside them. ([@jonas054][]) | |||
There was a problem hiding this comment.
This should be in the master section. I cut 0.35.1 yesterday because of the caching bug.
If the string is dynamic and has double quote characters inside it, then `%Q` is warranted. We had a spec example for this already, but it contained a backslash that shouldn't be there.
jonas054
force-pushed
the
2413_fix_unneeded_percent_q
branch
from
e68777c
to
dc45530
Compare
|
Fixed changelog. |
bbatsov
added a commit
that referenced
this pull request
Nov 11, 2015
Allow `%Q` for dynamic strings with double quotes inside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the string is dynamic and has double quote characters inside it, then
%Qis warranted. We had a spec example for this already, but it contained a backslash that shouldn't be there.