Detect degenerated workarounds for Style/NumericLiterals #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Dec 13, 2016
| @@ -16,6 +16,7 @@ | |||
| * [#3451](https://github.com/bbatsov/rubocop/issues/3451): Add new `require_parentheses_when_complex` style to `Style/TernaryParentheses` cop. ([@swcraig][]) | |||
| * [#3600](https://github.com/bbatsov/rubocop/issues/3600): Add new `Bundler/OrderedGems` cop. ([@tdeo][]) | |||
| * [#3479](https://github.com/bbatsov/rubocop/issues/3479): Add new configuration option `IgnoredPatterns` to `Metrics/LineLength`. ([@jonas054][]) | |||
| * [#3749](https://github.com/bbatsov/rubocop/pull/3749): Detect corner case of `Style/NumericLitterals`. ([@kamaradclimber][]) | |||
There was a problem hiding this comment.
This should be moved the the master section of the readme.
|
Apart from my small remark - the change looks good to me. |
Users might be tempted to replace 8192 by 819_2 without understanding the underscore as a thousand separator Change-Id: If97f6c0ebdedf69df36530168a385f4a896a0a39
|
@bbatsov thanks for you feedback, I've moved the changelog line to its proper place. |
|
@kamaradclimber, @bbatsov I think, this is a bad idea. We use money objects which we initialize with cents, so to get $123,456.78, we used Instead on enforcing this, I'd rather provide a better offense message explaining the proper usage. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users might be tempted to replace 8192 by 819_2 without
understanding the underscore as a thousand separator
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).