Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3918] Prevent Rails/EnumUniqueness from breaking on a non-literal hash value #3920

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Drenmi
Copy link
Collaborator

@Drenmi Drenmi commented Jan 16, 2017

This cop would break on any enum hash that did not have a literal value. This change fixes that.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

…non-literal hash value

This cop would break on any enum hash that did not have a literal value.
This change fixes that.
@bbatsov bbatsov merged commit de4e4c5 into rubocop:master Jan 16, 2017
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 16, 2017

👍

@Drenmi Drenmi deleted the bugfix/enum-uniqueness-cop branch February 11, 2017 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants